Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HfFileSystem] Less /paths-info calls #2271

Merged
merged 2 commits into from May 21, 2024
Merged

[HfFileSystem] Less /paths-info calls #2271

merged 2 commits into from May 21, 2024

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented May 6, 2024

...or we get rate-limited in the dataset viewer (e.g. for FineWeb)

cc @severo

@lhoestq lhoestq requested a review from Wauplin May 6, 2024 12:25
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq
Copy link
Member Author

lhoestq commented May 13, 2024

This is also causing bugs in datasets when loading datasets with many files, e.g. load_dataset('mteb/biblenlp-corpus-mmteb'):

huggingface_hub.utils._errors.HfHubHTTPError: 429 Client Error: Too Many Requests for url: https://huggingface.co/api/datasets/mteb/biblenlp-corpus-mmteb/paths-info/3912ed967b0834547f35b2da9470c4976b357c9a

could you take a look @Wauplin ? It would be cool to release this fix when you return :p

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual approval. @lhoestq have you tested it with datasets to check loading time is faster?

@lhoestq
Copy link
Member Author

lhoestq commented May 21, 2024

It's been in prod in datasets-viewer and it fixes the HfHubHTTPError (Too Many Requests) both for the FineWeb's viewer and also for loading the mmteb datasets in datasets

@Wauplin
Copy link
Contributor

Wauplin commented May 21, 2024

Great, thanks for confirming 👍

@Wauplin Wauplin merged commit ec09a05 into main May 21, 2024
16 checks passed
@Wauplin Wauplin deleted the less-paths-info-calls branch May 21, 2024 16:14
Wauplin pushed a commit that referenced this pull request May 21, 2024
* less paths-info calls

* fix tests
@Wauplin
Copy link
Contributor

Wauplin commented May 21, 2024

@lhoestq
Copy link
Member Author

lhoestq commented May 21, 2024

thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants