Update workspace #251
Open
Update workspace #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
smalluban
requested changes
Apr 12, 2024
| "trailingComma": "all" | ||
| "trailingComma": "all", | ||
| "editorconfig": true, | ||
| "printWidth": 160 |
There was a problem hiding this comment.
This is a styling change, not additional metadata, which is suppose to help users using some editors. Please remove that change.
| @@ -0,0 +1,12 @@ | |||
| # EditorConfig is awesome: https://EditorConfig.org | |||
There was a problem hiding this comment.
This is essentially not required at all, as the prettier does the job. You just need to enable it in your editor. I would rather add a suggestion for adding a prettier plugin for vs code (esbenp.prettier-vscode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have enabled source code formatting to match the code style for VSCode.
Try
Alt+Shift+ForFormat filein the context menu, but don't forget to install the npm packages first.