Fixed it so Ka0s repacks work on linux #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
found a bug with the yaml generating. fixing it then commiting |
lilezek
approved these changes
May 1, 2024
Magrid0
approved these changes
May 1, 2024
…a varible instead.
lilezek
approved these changes
May 1, 2024
| @@ -27,8 +27,11 @@ const openGameInstaller = async ( | |||
| return true; | |||
| } | |||
|
|
|||
| const setupPath = path.join(gamePath, "setup.exe"); | |||
| if (!fs.existsSync(setupPath)) { | |||
| const files = fs.readdirSync(gamePath); | |||
There was a problem hiding this comment.
Maybe it makes sense to turn this into a helper function at this point. Any hardcoded names would work fine in windows but may break in linux if name changes capitalization.
|
Turns out Kaos repacks installer does not work at all on Linux, i reached out to them to try to get a resolution to get it working with hydra. |
hydralauncher
suggested changes
May 2, 2024
|
|
||
| export const generateYML = (game: Game) => { | ||
| const slugifiedGameTitle = game.title.replace(/\s/g, "-").toLocaleLowerCase(); | ||
| const gamePath = path.join(game.downloadPath, game.folderName); | ||
|
|
||
| const files = fs.readdirSync(gamePath); |
There was a problem hiding this comment.
Please don't use synchronous operations when using I/O since this might potentially lock the main thread
| @@ -41,4 +43,4 @@ export const generateYML = (game: Game) => { | |||
| }); | |||
|
|
|||
| return doc.toString(); | |||
| }; | |||
| }; | |||
| const setupFileName = files.find(file => /^setup\.exe$/i.test(file)); | ||
| const setupPath = setupFileName ? path.join(gamePath, setupFileName) : null; | ||
|
|
||
| if (!setupPath || !fs.existsSync(setupPath)) { |
There was a problem hiding this comment.
Don't use synchronous I/O operations
|
Closing this since I haven't had any updates in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed it so Ka0s repacks work on linux, its using Setup.exe instead of setup.exe.
Side-note:
Should i implement it so if nether setup.exe or Setup.exe is found it prompts the user to select the installer executable?