Allow us to start games on linux using hydra and lutris. #155
Conversation
…ylli251/hydra into linux_proton_open_game_support
|
Done. not sure about the merge conflicts can you take a look @hydralauncher ? |
|
@gylli251 could you resolve them? |
| if (process.platform === 'linux') { | ||
| const { stdout: lutrisPath } = await exec('which lutris'); | ||
| if (lutrisPath.trim()) { | ||
| await exec(`chmod +x "${executablePath}"`); |
There was a problem hiding this comment.
Give execution permission to a file that will be downloaded from the internet can lead to major security issues and, as far as I can see, we are doing it without even telling the user about it.
I understand why it's important, but I really believe that it should not be there. We do not handle game installation and we should not handle file permissioning either.
There was a problem hiding this comment.
Like i said in the original PR:
"it uses the lutris runtime thats default to run the executable. sadly it needs to make the .exe execute permissions but don't see a way around that."
Lutris does not run games without making the .exe an executable. dont see a way around it unless we want to make it a popup for the user to select which .exe to make executable?
Or we can look into using some other tool then lutris
There was a problem hiding this comment.
We did succeed on running .exe files when going straight to Wine. It could be a good idea for this feature too as we could skip one layer of software. Even though we stick to calling Lutris, I would rather to let the user take care of this itself, maybe giving him some hints?
Allow us to start games on linux using hydra and lutris.
So far just works, if somebody else can test it with me it would be great.
it uses the lutris runtime thats default to run the executable. sadly it needs to make the .exe execute permissions but don't see a way around that.
also changed the way the select and executable its not windows only.
Note that maybe its better to do the detection of what OS is running some way else then using "which lutris"