Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to install games on linux #304

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

scrlkx
Copy link

@scrlkx scrlkx commented May 12, 2024

There is a issue when installing games on Linux. I described it in #299.

Fixes #299

@scrlkx scrlkx changed the title fix: game installing do not reach linux steps fix: unable to install games on linux May 26, 2024
@zamitto
Copy link
Collaborator

zamitto commented May 26, 2024

Finally got able to install a linux disto on my PC, will test your PR today

@zamitto
Copy link
Collaborator

zamitto commented May 27, 2024

Gonna post here the same commend I posted on #299 just to make it more visible:

May I suggest something?

  1. If there is a setup.exe inside the gamePath, we call wine ${setupPath} and return
  2. If there is not a setup.exe but there is any other .exe file, we call wine ${gamePath}
  3. If not, we open the directory using shell.openPath(gamePath)

The Windows conditional remains the same as it is in your PR. These checks should happen after that.

@zamitto zamitto added this to the v1.3.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Installers are not handled correctly on Linux (using Lutris or Wine)
3 participants