[3.0]Add gRPC extensibility #5047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
单测再改一下吧 |
|
这个是不是可以考虑加多一个。Router::GRPC() 的方法，不再用之前的那种做法 |
|
Router::gRPC 考虑放到新的 PR 里，如果校验 path 还要考虑路由嵌套和注解 |
|
有空帮看一下 @limingxinleo @PandaLIU-1111 |
| * @param mixed $deserialize | ||
| * @return \Grpc\StringifyAble[]|Message[]|\swoole_http2_response[] | ||
| */ | ||
| public static function parseResponse($response, $deserialize): array |
There was a problem hiding this comment.
为什么这个移到了 GrpcClient 这里去了，没太理解
There was a problem hiding this comment.
@PandaLIU-1111 因为要在这里面抛出 GrpcClientException，这个文件在grpc-client
一种选择是将 GrpcClientException 移入到 grpc 包，当前选择的是下放 parseResponse，而且parseResponse只有客户端需要
kids-return
force-pushed
the
3.0-grpc-client
branch
from
af04374
to
28bed53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5013