Add Backoff Utilities #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasno
force-pushed
the
retryUtil
branch
5 times, most recently
from
4479130
to
db053c7
Compare
limingxinleo
reviewed
Nov 1, 2019
src/utils/src/Backoff.php
Outdated
| usleep($sleep * 1000); | ||
| //update backoff using Decorrelated Jitter | ||
| //see: https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/ | ||
| $sleep = rand($firstMs, $sleep * 3); |
There was a problem hiding this comment.
不是 是第一次重试和上一次重试3倍之间的一个随机数，具体算法是https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter 这里提出的Decorrelated Jitter
|
最后还是选择了OOP而不是闭包，便于依赖注入 |
limingxinleo
reviewed
Nov 1, 2019
limingxinleo
approved these changes
Nov 1, 2019
|
@Reasno 还有其他要补充的么？我觉得 OK 的。 |
|
没有了 想把重启进程改成backoff的，另开PR吧。 |
|
进程重启要不就不要改了吧。。因为按照现在的逻辑，假设出现问题。。 那就需要 1min 后才能重启，就算服务正常了。。 因为有一个常规重启逻辑，每当执行完多少次会重启的逻辑。。 |
|
async-queue 有一个 消费多少个消息后自动重启的功能 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation of #824