Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set inputs() default value #835

Merged
merged 4 commits into from Nov 1, 2019
Merged

fix: set inputs() default value #835

merged 4 commits into from Nov 1, 2019

Conversation

daydaygo
Copy link
Member

@daydaygo daydaygo commented Nov 1, 2019 •
edited by limingxinleo

fix #819

limingxinleo
limingxinleo reviewed Nov 1, 2019
View reviewed changes
src/http-server/src/Request.php Outdated
@@ -96,7 +96,7 @@ public function inputs(array $keys, $default = null): array
$result = $default ?? [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那这一行代码应该就没用了吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦 不对，也有用。。

@limingxinleo limingxinleo merged commit 809a418 into hyperf:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limingxinleo limingxinleo limingxinleo approved these changes

@huangzhhui huangzhhui Awaiting requested review from huangzhhui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] request->inputs方法设置默认值不生效
2 participants
@daydaygo @limingxinleo