Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge config rather than replace #2558

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

chore: merge config rather than replace #2558

wants to merge 2 commits into from

Conversation

liuseen-l
Copy link

close: #2386

iamkun
iamkun reviewed Apr 29, 2024
View reviewed changes
src/plugin/updateLocale/index.js
const customOriginConfig = customConfig[c]
if (originConfig !== null && typeof originConfig === 'object' && typeof customOriginConfig === 'object') {
localeConfig[c] = {
...originConfig,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Day.js is a lib targeting es5, please do not use es6 syntax like ... (Destructuring assignment) or Object.assign in the code. This will lead significant bundle size increase.

Please consider using some simple code like for loop or Object.keys to iterate the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the updateLocale Plugin should merge config rather than replace it
2 participants
@liuseen-l @iamkun