Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use numerals in relative time formatter in FI locale #2590

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sergioisidoro
Copy link

Fixes #2589

@iamkun
Copy link
Owner

iamkun commented Apr 27, 2024

Sorry, I am not a native speaker, and just wondering if it would be better if we follow https://github.com/moment/moment/blob/develop/src/locale/fi.js?

@sergioisidoro
Copy link
Author

sergioisidoro commented Apr 27, 2024

Hi @iamkun thanks for taking the time to check this out.

Did you have the chance to read my rationale in the issue? I tried to explain the reason for this proposal there.

@iamkun
Copy link
Owner

iamkun commented Apr 28, 2024

Thanks for the PR as well as the relative issue.

I've read the editorial and the solution, however, maybe I am not the one who can make the decision.

It will be better to keep this PR open until some native speakers review it, or just keep the same with moment.js at present, which is safer.

@sergioisidoro
Copy link
Author

That sounds very reasonable :)
Just as a contextual information - I'm not native, but I've been living in Finland for 10 years, and I have consulted with a native speaker before making this proposal. But I think it makes sense to wait for a second opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locale FI - breaks from other languages in relative time format
2 participants