forked from cms-sw/cmssw
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing dildick's comments for pull request 2304 #9
Merged
ianna
merged 91 commits into
ianna:new-geometry-scenarios
from
mark-grimes:mergeIanna_new-geometry-scenarios
Feb 18, 2014
Merged
Implementing dildick's comments for pull request 2304 #9
ianna
merged 91 commits into
ianna:new-geometry-scenarios
from
mark-grimes:mergeIanna_new-geometry-scenarios
Feb 18, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack-ward compatible
… are included automatically
…eed to be done properly)
fix tracker.xml
For gem muon reco
Correct v4 for mixed 9-10 eta partition geometry
…eometry-integration Gem rpc phase ii geometry integration
Phase2 HE pedestal analysis
Changes to get tests 3400 and 15001 to use the correct customisation for harvesting
SLHC Digi validation fix
…eIanna_new-geometry-scenarios
ianna
added a commit
that referenced
this pull request
Feb 18, 2014
Implementing dildick's comments for pull request 2304
ianna
pushed a commit
that referenced
this pull request
Mar 11, 2014
Adding L1 to GEM customizations
ianna
pushed a commit
that referenced
this pull request
Mar 11, 2014
ianna
pushed a commit
that referenced
this pull request
Apr 3, 2014
Merge tkdbmonitoring_70x into tkdbmonitoring_71x
ianna
pushed a commit
that referenced
this pull request
Jun 12, 2015
PRToFixMess_GEMCSCSegment_PR_v3
ianna
pushed a commit
that referenced
this pull request
Aug 26, 2015
New charge cleaner module for taus
ianna
pushed a commit
that referenced
this pull request
Jul 18, 2017
using triggerSummary instead of TriggerResults
ianna
pushed a commit
that referenced
this pull request
Dec 3, 2018
Default not predicted values to -1, use auto descriptions
ianna
pushed a commit
that referenced
this pull request
Jun 17, 2019
Fixed some errors and create a new method printInputs
ianna
pushed a commit
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had a go implementing @dildick's comments for cms-sw#2304. Could you check and update the pull request please? Do check in case I've misunderstood though. I'm not sure why the diff is showing so many file changes, I guess the original branch was based on an older IB - you might find it easier to implement yourself than merge this in. When rebased onto the current CMSSW_6_2_X_SLHC these are the only differences: