Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing dildick's comments for pull request 2304 #9

Merged

Conversation

mark-grimes
Copy link

Hi,
I had a go implementing @dildick's comments for cms-sw#2304. Could you check and update the pull request please? Do check in case I've misunderstood though. I'm not sure why the diff is showing so many file changes, I guess the original branch was based on an older IB - you might find it easier to implement yourself than merge this in. When rebased onto the current CMSSW_6_2_X_SLHC these are the only differences:

diff --git a/Geometry/CMSCommonData/python/cmsExtendedGeometry2023CFCalXML_cfi.py b/Geometry/CMSCommonData/python/cmsExtendedGeometry2023CFCalXML_cfi.py
index 8df7a2d..5ad0d5f 100644
--- a/Geometry/CMSCommonData/python/cmsExtendedGeometry2023CFCalXML_cfi.py
+++ b/Geometry/CMSCommonData/python/cmsExtendedGeometry2023CFCalXML_cfi.py
@@ -111,7 +111,7 @@ XMLIdealGeometryESSource = cms.ESSource("XMLIdealGeometryESSource",
         'Geometry/CSCGeometryBuilder/data/cscSpecsFilter.xml',
         'Geometry/CSCGeometryBuilder/data/cscSpecs.xml',
         'Geometry/RPCGeometryBuilder/data/RPCSpecs.xml',
-        'Geometry/GEMGeometryBuilder/data/v4/GEMSpecs.xml',
+        'Geometry/GEMGeometryBuilder/data/v5/GEMSpecs.xml',
         'Geometry/ForwardCommonData/data/brmsens.xml',
         'Geometry/ForwardSimData/data/castorsens.xml',
         'Geometry/ForwardSimData/data/zdcsens.xml',
diff --git a/Geometry/CMSCommonData/python/cmsExtendedGeometry2023SHCal4EtaXML_cfi.py b/Geometry/CMSCommonData/python/cmsExtendedGeometry2023SHCal4EtaXML_cfi.py
index 61cb209..d91b62e 100644
--- a/Geometry/CMSCommonData/python/cmsExtendedGeometry2023SHCal4EtaXML_cfi.py
+++ b/Geometry/CMSCommonData/python/cmsExtendedGeometry2023SHCal4EtaXML_cfi.py
@@ -111,7 +111,6 @@ XMLIdealGeometryESSource = cms.ESSource("XMLIdealGeometryESSource",
         'Geometry/CSCGeometryBuilder/data/cscSpecsFilter.xml',
         'Geometry/CSCGeometryBuilder/data/cscSpecs.xml',
         'Geometry/RPCGeometryBuilder/data/RPCSpecs.xml',
-        'Geometry/GEMGeometryBuilder/data/v4/GEMSpecs.xml',
         'Geometry/ForwardCommonData/data/brmsens.xml',
         'Geometry/ForwardSimData/data/castorsens.xml',
         'Geometry/ForwardSimData/data/zdcsens.xml',

ianna and others added 30 commits December 20, 2013 16:29
ianna added a commit that referenced this pull request Feb 18, 2014
Implementing dildick's comments for pull request 2304
@ianna ianna merged commit 50f5627 into ianna:new-geometry-scenarios Feb 18, 2014
ianna pushed a commit that referenced this pull request Mar 11, 2014
ianna pushed a commit that referenced this pull request Mar 11, 2014
ianna pushed a commit that referenced this pull request Apr 3, 2014
Merge tkdbmonitoring_70x into tkdbmonitoring_71x
ianna pushed a commit that referenced this pull request Jun 30, 2014
@mark-grimes mark-grimes deleted the mergeIanna_new-geometry-scenarios branch March 23, 2015 17:11
ianna pushed a commit that referenced this pull request Jun 12, 2015
PRToFixMess_GEMCSCSegment_PR_v3
ianna pushed a commit that referenced this pull request Aug 26, 2015
New charge cleaner module for taus
ianna pushed a commit that referenced this pull request Jul 11, 2017
ianna pushed a commit that referenced this pull request Jul 18, 2017
using triggerSummary instead of TriggerResults
ianna pushed a commit that referenced this pull request Dec 3, 2018
Default not predicted values to -1, use auto descriptions
ianna pushed a commit that referenced this pull request Jun 17, 2019
 Fixed some errors and create a new method printInputs
ianna pushed a commit that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants