Allow frozen objects/arrays to be coerced #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturmuller
added a commit
to superstructjs/superstruct
that referenced
this pull request
Nov 3, 2023
* Update tuple coercer * Update record coercer * Add frozen objects/arrays tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug
The issue was the mutation of the input object/array while coercing entries inside the
runutil -- combined with a missing custom coercer which would clone its input (exactly as @gwisp2 suggested in #1096).Apart from
record,tuplewas also affected by the same potential issue.PR Changes
recordandtuple.Resolves #1096