Accept api changes due to validation refactoring

ical4j · Jan 6, 2022 · d5c4c66 · d5c4c66
1 parent d0a6ea2
commit d5c4c66
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 4 deletions.
diff --git a/.palantir/revapi.yml b/.palantir/revapi.yml
@@ -340,6 +340,18 @@ acceptedBreaks:
       old: "class net.fortuna.ical4j.validate.PropertyValidator"
       new: "class net.fortuna.ical4j.validate.PropertyValidator<T extends net.fortuna.ical4j.model.Property>"
       justification: "Refatoring validation framework"
+    - code: "java.field.removedWithConstant"
+      old: "field net.fortuna.ical4j.validate.PropertyValidator.ASSERT_NONE_MESSAGE"
+      justification: "Refactoring"
+    - code: "java.field.removedWithConstant"
+      old: "field net.fortuna.ical4j.validate.PropertyValidator.ASSERT_ONE_MESSAGE"
+      justification: "Refactoring"
+    - code: "java.field.removedWithConstant"
+      old: "field net.fortuna.ical4j.validate.PropertyValidator.ASSERT_ONE_OR_LESS_MESSAGE"
+      justification: "Refactoring"
+    - code: "java.field.removedWithConstant"
+      old: "field net.fortuna.ical4j.validate.PropertyValidator.ASSERT_ONE_OR_MORE_MESSAGE"
+      justification: "Refactoring"
     - code: "java.generics.elementNowParameterized"
       old: "class net.fortuna.ical4j.validate.PropertyValidator"
       new: "class net.fortuna.ical4j.validate.PropertyValidator<T extends net.fortuna.ical4j.model.Property>"
@@ -352,3 +364,19 @@ acceptedBreaks:
       old: "method void net.fortuna.ical4j.validate.component.VTimeZoneValidator::<init>(net.fortuna.ical4j.validate.ValidationRule[])"
       new: "method void net.fortuna.ical4j.validate.component.VTimeZoneValidator::<init>()"
       justification: "Refatoring validation framework"
+    - code: "java.method.removed"
+      old: "method void net.fortuna.ical4j.validate.PropertyValidator::assertNone(java.lang.String,\
+        \ net.fortuna.ical4j.model.PropertyList) throws net.fortuna.ical4j.validate.ValidationException"
+      justification: "Refactoring"
+    - code: "java.method.removed"
+      old: "method void net.fortuna.ical4j.validate.PropertyValidator::assertOne(java.lang.String,\
+        \ net.fortuna.ical4j.model.PropertyList) throws net.fortuna.ical4j.validate.ValidationException"
+      justification: "Refactoring"
+    - code: "java.method.removed"
+      old: "method void net.fortuna.ical4j.validate.PropertyValidator::assertOneOrLess(java.lang.String,\
+        \ net.fortuna.ical4j.model.PropertyList) throws net.fortuna.ical4j.validate.ValidationException"
+      justification: "Refactoring"
+    - code: "java.method.removed"
+      old: "method void net.fortuna.ical4j.validate.PropertyValidator::assertOneOrMore(java.lang.String,\
+        \ net.fortuna.ical4j.model.PropertyList) throws net.fortuna.ical4j.validate.ValidationException"
+      justification: "Refactoring"
diff --git a/Makefile b/Makefile
@@ -1,7 +1,11 @@
 SHELL:=/bin/bash
 include .env
 
-.PHONY: all gradlew clean build zoneinfo changelog currentVersion markNextVersion listApiChanges approveApiChanges release publish
+NEXT_VERSION=$(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS))
+CHANGE_JUSTIFICATION=$(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS))
+
+.PHONY: all gradlew clean build zoneinfo changelog currentVersion markNextVersion listApiChanges approveApiChanges \
+	verify release publish
 
 all: test
 
@@ -30,17 +34,18 @@ currentVersion:
 	./gradlew -q currentVersion
 
 markNextVersion:
-	NEXT_VERSION=$(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS))
 	./gradlew markNextVersion -Prelease.version=$(NEXT_VERSION)
 
 listApiChanges:
 	./gradlew revapi
 
 approveApiChanges:
-	CHANGE_JUSTIFICATION=$(wordlist 2,$(words $(MAKECMDGOALS)),$(MAKECMDGOALS))
 	./gradlew :revapiAcceptAllBreaks --justification $(CHANGE_JUSTIFICATION)
 
-release: build
+verify:
+	./gradlew verify
+
+release: verify
 	./gradlew release
 
 publish: