-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] create DateProperty with TzId, it's timeZone is null. #134
Open
gihyun-jeon
wants to merge
7
commits into
ical4j:master
Choose a base branch
from
gihyun-jeon:feature/DateProperty_constructor_with_tzid
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[fix] create DateProperty with TzId, it's timeZone is null. #134
gihyun-jeon
wants to merge
7
commits into
ical4j:master
from
gihyun-jeon:feature/DateProperty_constructor_with_tzid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameterList has TZID then updateTimeZone.
gihyun-jeon
changed the title
[fix] create with TzId DateProperty, dose not have timeZone
[fix] create DateProperty with TzId, it's timeZone is null.
Mar 31, 2017
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
============================================
+ Coverage 68.66% 69.24% +0.58%
+ Complexity 2104 2024 -80
============================================
Files 334 305 -29
Lines 8808 8155 -653
Branches 1258 1177 -81
============================================
- Hits 6048 5647 -401
+ Misses 2326 2091 -235
+ Partials 434 417 -17
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
DateProperty
with difference constructor from same ical4jFormatDatetimeString and zoneId.But
DateProperty
instances are not same.So, modifed code.
when
DateProperty
constructor find Tzid, update itself's timeZone.