Fixed windows illegal character bug #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idlesign
reviewed
Apr 24, 2021
| val = val.replace(i, '') | ||
| return val | ||
|
|
||
| if os.name == 'nt': |
There was a problem hiding this comment.
Let's define an OS appropriate sanitize function at class level (so it's constructed once at module import level).
Also this function will require some tests with os.name mocking to ensure the behaviour.
There was a problem hiding this comment.
Will get around to it this weekend. FYI, the existing tests seem to fail on my Windows machine (has something to do with how the encoded Russian language .cues are loaded, didn't look too much further into it). Will try to investigate it.
|
Link #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed windows illegal character bug resulting in failed creation of FLAC files.
Added pruning for illegal characters in windows + striping trailing spaces and dots from directories.