Skip to content
This repository has been archived by the owner on Oct 11, 2019. It is now read-only.

Fix the data passed in page:done event #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PikachuEXE
Copy link

#62 breaks what the readme says about data:

page:done ($target, status, url, data)

Event is triggered if the request succeeds.

    $target – jQuery object that was updated with the request;

    status – a string describing the status;

    url – url of the request;

    data – content of the request;

Now it always passes the target DOM, but I expect a full document when it is returned by request from server/browser cache to do some custom update

@PikachuEXE
Copy link
Author

@igor-alexandrov
I would like to have some clarification on data – content of the request
Is it intended to be always the content of request or only the target DOM?

@PikachuEXE
Copy link
Author

@igor-alexandrov Please take a look if you have time :)

@PikachuEXE
Copy link
Author

@igor-alexandrov Can you take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant