Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watershed workflow #1437

Open
wants to merge 113 commits into
base: main
Choose a base branch
from
Open

Watershed workflow #1437

wants to merge 113 commits into from

Conversation

shaker6691
Copy link

  1. Documentation expansion to get a faster introduction in implementing an applet and a workflow
  2. Watershed Workflow including
  • data selection
  • seeds applet
  • watershedSegmentation applet
  • data export
  1. seeds applet:
    includes the generation of seeds
  2. watershedSegmentation applet:
    the manual manipulation of seeds ist possible. the seeds can be reset to the initial seeds, so that all changes are removed.
    The watershed algorithm can be executed on boundaries and seeds (if seeded)
    The pixel value of the LabelCache can be displayed

pixelClassification. Daher jetzt PixelClassification bearbeiten
…rshed Applet und Workflow; keine Aenderungen zum letzten Commit, nur ein Anhaltspunkt
stuarteberg and others added 27 commits February 1, 2017 18:11
to integrate the changes in the master in the watershed_workflow branch
@@ -77,6 +77,7 @@ def main():
# Provide your command-line args here. See examples below.

## Auto-open an existing project
parsed_args.project='/home/andreas/MyProject.ilp'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove all of these lines? Or leave just one in as an example, but not add more?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, one line would be nice as an example but more are not needed. If you would like to remove it, the nice2know.rst file contains some information on the as well.

@@ -310,6 +356,72 @@ def _create_grayscale_layer_from_slot(cls, slot, n_channels):
return layer

@classmethod
def createGrayscaleLayer(cls, slot):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need these functions? There is already an addGrayscaleLayer in the viewer, what's the advantage of this function? I don't mind adding it if you think it makes developer life easier, just want to avoid too many functions doing almost the same thing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function createGrayscaleLayer seems to be redundant as you said. I found just the method GrayscaleLayer and this needs a source/lazyflowsource. Maybe you add a comment on how you use the addGrayscaleLayer and replace the one I used in the code.
So that next programmers easily find the function and know how to use it.

I guess, _create_single_color_layer_from_slot and create_8bit_ordered_random_colortable_layer_from_slot are not needed either. but the one with transparent zero is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants