Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump python version #2703

Merged
merged 9 commits into from Jun 27, 2023
Merged

bump python version #2703

merged 9 commits into from Jun 27, 2023

Conversation

k-dominik
Copy link
Contributor

@k-dominik k-dominik commented May 3, 2023 •
edited

@k-dominik k-dominik changed the title Python39 bump python version May 3, 2023
@k-dominik k-dominik force-pushed the python39 branch 8 times, most recently from 6c1ff3f to 80daa28 Compare May 9, 2023 17:54
@k-dominik k-dominik marked this pull request as ready for review May 10, 2023 10:43
@k-dominik k-dominik mentioned this pull request May 11, 2023
Merged
1 task
@k-dominik
Copy link
Contributor Author

pending ilastik/volumina#302

@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: +0.39 🎉

Comparison is base (fccb7dc) 53.57% compared to head (b2c5892) 53.97%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2703      +/-   ##
==========================================
+ Coverage   53.57%   53.97%   +0.39%     
==========================================
  Files         530      530              
  Lines       61412    62193     +781     
  Branches     8455     8478      +23     
==========================================
+ Hits        32901    33567     +666     
- Misses      26831    26952     +121     
+ Partials     1680     1674       -6
Impacted Files Coverage Δ
...low/operators/ioOperators/opExportMultipageTiff.py 92.00% <ø> (ø)

... and 229 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

emilmelnikov
emilmelnikov approved these changes Jun 26, 2023
View reviewed changes
conda-recipe/meta.yaml Show resolved Hide resolved
conda-recipe/meta.yaml Outdated Show resolved Hide resolved
dev/environment-dev.yml Outdated Show resolved Hide resolved
tests/test_ilastik/widgets/test_ImageFileDialog.py Outdated Show resolved Hide resolved
@k-dominik
bump python version
6f8490e 
also we agreed to drop support for tensorflow 1.x in ilastik 1.4.1
@k-dominik
bump pytorch version
8390f75
@k-dominik
fix OpExportMultipageTiff
30558cd 
tifffile requires Iterator, not iterable.
Would hang otherwise.
@k-dominik
pin grpcio because of segfaults on osx
d9c4e20
@k-dominik
Use fully Python 3.9 compatible volumina
01afc8a 
1.3.10 includes python 3.9 fixes
@k-dominik
bump pqyt to 5.15
e23b14b
@k-dominik
update conda before installing anything
fd34435
@k-dominik
skip file dialog tests on win gh ci
763bd2f 
these tests block/hang unfortunately - I tried multiple variants but
could not make it work on ci.

Works fine locally...
@k-dominik
Add compatibility note for python 3.7
b2c5892 
tifffile follows the numpy deprecation schedule and dropped support for 3.7.

ref: https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule
@k-dominik k-dominik merged commit 629932d into ilastik:main Jun 27, 2023
16 checks passed
@k-dominik k-dominik deleted the python39 branch June 27, 2023 09:30
@k-dominik k-dominik mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilmelnikov emilmelnikov emilmelnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-dominik @emilmelnikov