Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar issues #2925

Merged
merged 21 commits into from
May 4, 2024
Merged

Fix sonar issues #2925

merged 21 commits into from
May 4, 2024

Commits on May 3, 2024

  1. Remove unused member which was also causing a false positive sonar is… 

    …sue.

Fixes sonar issue https://sonarcloud.io/project/issues?open=AY3gHwu5DIZTZkppqVEG&id=iluwatar_java-design-patterns
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f362f9f View commit details
    Browse the repository at this point in the history

  2. Fixes sonar issue https://sonarcloud.io/project/issues?open=AXK0OzDA-… 

    …CiGJS70dLki&id=iluwatar_java-design-patterns

related to "Refactor the code of the lambda to not have multiple invocations throwing the same checked exception."

Also, updated the code to use Instant and Duration to deal with time instead of int. Added the awaitility
library to perform assertions in test which is more reliable than using Thread.sleep directly to wait for events to happen.
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    20a53ea View commit details
    Browse the repository at this point in the history

  3. checkstyle fix

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b19c656 View commit details
    Browse the repository at this point in the history

  4. Add sneaky throws to fix sonar lint issue. This is fine as the newFil… 

    …e method is not being tested but instead the new SimpleFileWriter(...) is.
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7f071f7 View commit details
    Browse the repository at this point in the history

  5. The first booking needs to happen outside the assertions. Fixed other… 

    … warnings
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ab47158 View commit details
    Browse the repository at this point in the history

  6. Use records to pass around related objects instead of using a large n… 

    …umber of

individual params, which sonar did not like.
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fbf5af5 View commit details
    Browse the repository at this point in the history

  7. Checkstyle fixes

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f8c2e61 View commit details
    Browse the repository at this point in the history

  8. checkstyle fixes

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    db4ba8a View commit details
    Browse the repository at this point in the history

  9. Remove complexity to keep sonar happy.

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2e0f578 View commit details
    Browse the repository at this point in the history

  10. Split into different methods to reduce complexity. Could be broken do… 

    …wn even further but currently Sonar is happy.
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    10ccc10 View commit details
    Browse the repository at this point in the history

  11. Move files to correct package

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    61930fd View commit details
    Browse the repository at this point in the history

  12. Add valid assertions to tests

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    aafd8ae View commit details
    Browse the repository at this point in the history

  13. rename constants to avoid confusion

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2231ef8 View commit details
    Browse the repository at this point in the history

  14. Sonar warning related to cognitive complexity can be suppressed as th… 

    …e methods are quite generic and not functional enough to be separated out.
    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    64f9b6d View commit details
    Browse the repository at this point in the history

  15. Use constants to keep Sonar happy

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4b0e44b View commit details
    Browse the repository at this point in the history

  16. Use correct constant naming conventions

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d6a6314 View commit details
    Browse the repository at this point in the history

  17. Use correct constant naming conventions

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d8d39ff View commit details
    Browse the repository at this point in the history

  18. Use lombok to define noargsconstructor

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b045d53 View commit details
    Browse the repository at this point in the history

  19. Use a single method to do the logging

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a270520 View commit details
    Browse the repository at this point in the history

  20. Remove unused constructor and redundant method

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    04090db View commit details
    Browse the repository at this point in the history

  21. Use a reusable method for logging

    @k1w1dev
    k1w1dev committed May 3, 2024
    Configuration menu
    Copy the full SHA
    db8f8e8 View commit details
    Browse the repository at this point in the history