Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex fix for using querystring variables starting with "w" or "h" #47

Closed
wants to merge 2 commits into from

Conversation

Jeavon
Copy link
Contributor

@Jeavon Jeavon commented Feb 19, 2015

No description provided.

@lilith
Copy link
Member

lilith commented Feb 19, 2015

Thanks! Can we add a corresponding unit test? I'll give you push access so you can get full Travis/Sauce tests to work.

@lilith
Copy link
Member

lilith commented Feb 19, 2015

@Jeavon
Copy link
Contributor Author

Jeavon commented Feb 19, 2015

Brilliant, thanks!
Just working on another strange issue with the new getCssValue method not working in Chrome, if I revert it to the v0.2 version it works. Will post further info later

@lilith
Copy link
Member

lilith commented Feb 19, 2015

Strange, we have test coverage for getCssValue on a variety of css units ('max-width' property only, though). Unit tests are run on chrome, android 4.0, 4.4, IE6-10, safari, firefox, ios simulator.

@Jeavon
Copy link
Contributor Author

Jeavon commented Feb 25, 2015

I've added a test, should I push to the unstable branch to get Travis/Sauce to work?

@lilith
Copy link
Member

lilith commented Feb 25, 2015

Yes, SauceLabs only works if it's on a real branch. 'unstable' is fine, although more complex stuff should get its own 'features/featurename' or 'bugfix/bugname' branch temporarily until alpha-level, then go into unstable from there.

@Jeavon Jeavon closed this Feb 26, 2015
@Jeavon Jeavon deleted the Regex_Fix branch February 26, 2015 09:21
@Jeavon
Copy link
Contributor Author

Jeavon commented Feb 26, 2015

Seems like it all worked and passed! Awesome setup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants