Search: Optimize (perf) execution of global facets, closes elastic#889.

imotov · Apr 28, 2011 · 887ac1f · 887ac1f
1 parent 2c0bb91
commit 887ac1f
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/modules/elasticsearch/src/main/java/org/elasticsearch/search/facet/FacetPhase.java b/modules/elasticsearch/src/main/java/org/elasticsearch/search/facet/FacetPhase.java
@@ -21,7 +21,6 @@
 
 import org.apache.lucene.search.*;
 import org.elasticsearch.ElasticSearchException;
-import org.elasticsearch.common.collect.ImmutableList;
 import org.elasticsearch.common.collect.ImmutableMap;
 import org.elasticsearch.common.collect.Lists;
 import org.elasticsearch.common.collect.Maps;
@@ -34,6 +33,7 @@
 import org.elasticsearch.search.query.QueryPhaseExecutionException;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
@@ -90,11 +90,10 @@ public class FacetPhase implements SearchPhase {
                     }
                     List<Collector> list = filtersByCollector.get(filter);
                     if (list == null) {
-                        list = ImmutableList.of(collector);
+                        list = new ArrayList<Collector>();
                         filtersByCollector.put(filter, list);
-                    } else {
-                        list.add(collector);
                     }
+                    list.add(collector);
                 }
             }
             // now, go and execute the filters->collector ones