Only include required files in IncludeOS nix package #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids rebuilding the OS from in-tree packages that depend on ./default.nix
bjornfor
reviewed
May 20, 2024
MagnusS
commented
May 20, 2024
They are only needed during eval. Changes in the derivation should trigger rebuild.
alfreb
pushed a commit
to alfreb/IncludeOS
that referenced
this pull request
Jun 3, 2024
Only include required files in IncludeOS nix package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids rebuilding the OS when working on in-tree packages that depend on
./default.nix, such as./example.nix.Also enables parallel building, but I'm not sure this affects build time at all.