Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated scripts to adopt eslint rule #35

Merged
merged 1 commit into from Feb 8, 2024

Conversation

getty104
Copy link
Member

How

This PR is for adopt eslint rule no-prototype-builtins.
https://eslint.org/docs/latest/rules/no-prototype-builtins

I fixed codes that is not adapted for no-prototype-builtins rule.

@getty104 getty104 self-assigned this Jan 31, 2024
@acronhub
Copy link

acronhub commented Feb 1, 2024

📝
https://github.com/eslint/eslint/blob/857e242584227181ecb8af79fc6bc236b9975228/lib/rules/no-prototype-builtins.js#L70-L74

The three target methods are

  • hasOwnProperty
  • isPrototypeOf
  • propertyIsEnumerable

@acronhub
Copy link

acronhub commented Feb 1, 2024

nits

https://github.com/increments/js_rails_routes/blob/master/README.md

  • I found the output code and thought I should fix this as well.

Copy link

@acronhub acronhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM because it was a small concern.

@getty104 getty104 force-pushed the update-generated-scripts-to-adopt-eslint-rule branch from 9489445 to 0330972 Compare February 1, 2024 07:31
Copy link

codeclimate bot commented Feb 1, 2024

Code Climate has analyzed commit 0330972 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 99.6% (0.0% change).

View more on Code Climate.

@getty104 getty104 merged commit 23d4180 into master Feb 8, 2024
9 of 13 checks passed
@getty104 getty104 deleted the update-generated-scripts-to-adopt-eslint-rule branch February 8, 2024 06:54
@getty104 getty104 mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants