Add support for parameters as Array #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohakutsu
reviewed
Apr 16, 2024
| @@ -11,7 +11,13 @@ class JavaScript < Base | |||
| var query = []; | |||
| for (var param in params) if (Object.prototype.hasOwnProperty.call(params, param)) { | |||
| if (keys.indexOf(param) === -1) { | |||
| query.push(param + "=" + encodeURIComponent(params[param])); | |||
| if (Array.isArray(params[param])) { | |||
| for (var value of params[param] as Value[]) { | |||
There was a problem hiding this comment.
Please remove type assertion, since it's JavaScript. 🙏
Suggested change
| for (var value of params[param] as Value[]) { | |
| for (var value of params[param]) { |
There was a problem hiding this comment.
Thank you for your feedback. I have made the suggested changes.
| @@ -7,14 +7,20 @@ module JSRailsRoutes | |||
| module Language | |||
| class TypeScript < JavaScript | |||
| PROCESS_FUNC = <<~TYPESCRIPT | |||
| type Value = string | number | |||
| type Value = string | number | Value[] | |||
There was a problem hiding this comment.
How about this instead, since we don't expect array of array?
Suggested change
| type Value = string | number | Value[] | |
| type Value = string | number | (string | number)[] |
There was a problem hiding this comment.
Thank you for your feedback. I have made the suggested changes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://edgeguides.rubyonrails.org/action_controller_overview.html#hash-and-array-parameters
This pull request introduces an enhancement to the js_rails_routes library by adding support for array parameters in URLs, aligning with the Ruby on Rails guideline for handling hash and array parameters.