Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call for Papers in React #4107

Merged
merged 21 commits into from Nov 7, 2019
Merged

Call for Papers in React #4107

merged 21 commits into from Nov 7, 2019

Conversation

mic4ael
Copy link
Member

@mic4ael mic4ael commented Oct 14, 2019 •
edited

WIP:

  • edit a comment
  • show/add/edit ratings
  • render fields
  • add/edit a review
  • remove old CSS classes and replace them with SUI-React
  • submit a revision

ThiefMaster
ThiefMaster reviewed Oct 21, 2019
View reviewed changes
indico/modules/events/papers/blueprint.py Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/actions.js Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/PaperContent.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/PaperDecisionForm.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/PaperInfo.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/schemas.py Outdated Show resolved Hide resolved
indico/modules/events/papers/schemas.py Outdated Show resolved Hide resolved
indico/modules/events/schemas.py Outdated Show resolved Hide resolved
indico/modules/events/schemas.py Outdated Show resolved Hide resolved
indico/web/client/js/react/components/MathJax.jsx Outdated Show resolved Hide resolved
@mic4ael mic4ael force-pushed the cfp-react branch 6 times, most recently from 01b145f to b5079c8 Compare October 23, 2019 12:20
@mic4ael mic4ael marked this pull request as ready for review October 23, 2019 12:21
@mic4ael mic4ael force-pushed the cfp-react branch 2 times, most recently from 79c7bce to 08a03af Compare October 25, 2019 09:08
@mic4ael mic4ael force-pushed the cfp-react branch 3 times, most recently from b0a0567 to d26a837 Compare October 28, 2019 12:32
ThiefMaster
ThiefMaster reviewed Oct 29, 2019
View reviewed changes
indico/web/client/js/react/components/FileSubmission.jsx Outdated Show resolved Hide resolved
indico/web/client/js/react/components/FileSubmission.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/setup.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/reducers.js Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/index.js Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionInfo.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionInfo.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionComment.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/PaperReviewForm.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/blueprint.py Outdated Show resolved Hide resolved
@mic4ael mic4ael force-pushed the cfp-react branch 2 times, most recently from f0b1ece to 768bed5 Compare October 30, 2019 08:03
ThiefMaster
ThiefMaster reviewed Oct 30, 2019
View reviewed changes
indico/modules/events/papers/client/js/components/RevisionComment.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionComment.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionComment.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/schemas.py Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionInfo.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionReview.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionReview.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/style/papers.scss Outdated Show resolved Hide resolved
indico/web/client/js/react/components/FileSubmission.jsx Show resolved Hide resolved
indico/web/client/js/react/components/FileSubmission.jsx Outdated Show resolved Hide resolved
@mic4ael mic4ael force-pushed the cfp-react branch 2 times, most recently from 429163d to 58b1408 Compare November 4, 2019 10:55
@mic4ael mic4ael force-pushed the cfp-react branch 2 times, most recently from 90b4143 to 9755fa3 Compare November 7, 2019 09:43
ThiefMaster
ThiefMaster reviewed Nov 7, 2019
View reviewed changes
indico/modules/events/papers/client/js/components/Paper.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/PaperReviewForm.jsx Outdated Show resolved Hide resolved
indico/modules/events/papers/client/js/components/RevisionComment.jsx Outdated
<Param name="userName" value={comment.user.fullName} wrapper={<strong />} /> left a
comment
</Translate>{' '}
{comment.visibility !== 'contributors' && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CommentVisibility enum?

@mic4ael mic4ael force-pushed the cfp-react branch 4 times, most recently from 70b3027 to 0fbd4c2 Compare November 7, 2019 10:28
@ThiefMaster ThiefMaster merged commit cff5173 into indico:master Nov 7, 2019
@ThiefMaster ThiefMaster deleted the cfp-react branch November 7, 2019 10:41
@pferreir pferreir mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panagiotappl panagiotappl panagiotappl left review comments

@meluru meluru meluru approved these changes

@pferreir pferreir pferreir approved these changes

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mic4ael @meluru @ThiefMaster @pferreir @panagiotappl