Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve editing timeline UI #6356

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Improve editing timeline UI #6356

merged 1 commit into from
Jun 4, 2024

Conversation

duartegalvao
Copy link
Member

This PR contains two improvements to the Editing Timeline's UI.

  • Grey out filebox when the files are outdated (superseded by a different revision): image
  • Increase the size of the revision tag dropdown menu
    image

tomasr8
tomasr8 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we got rid of the spacing for the background? looks a bit nicer imo, but your call ;)
image

@ThiefMaster
Copy link
Member

ThiefMaster commented May 22, 2024 •
edited

yep that'd look nicer for sure

@duartegalvao
Copy link
Member Author

What if we got rid of the spacing for the background? looks a bit nicer imo, but your call ;)

looks fine, but what if there's a revision comment on top there?

@duartegalvao
Copy link
Member Author

what about something like this? (removing that padding is a bitch 😅)
image

@duartegalvao duartegalvao requested a review from tomasr8 May 29, 2024 12:31
@ThiefMaster ThiefMaster added this to the v3.3 milestone Jun 4, 2024
@ThiefMaster ThiefMaster merged commit 1f6fe67 into indico:master Jun 4, 2024
9 checks passed
@ThiefMaster ThiefMaster deleted the timeline-ui-improvements branch June 4, 2024 15:33
micsucmed pushed a commit to micsucmed/indico that referenced this pull request Jun 11, 2024
@duartegalvao @micsucmed
Improve editing timeline UI (indico#6356)
29a9092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

@tomasr8 tomasr8 Awaiting requested review from tomasr8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@duartegalvao @ThiefMaster @tomasr8