fixing up the form focus in the admin area fixes #229

infinitas · Sep 6, 2010 · 3a6290d · 3a6290d
1 parent 83932cb
commit 3a6290d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/extensions/libs/webroot/js/infinitas.js b/extensions/libs/webroot/js/infinitas.js
@@ -23,15 +23,6 @@ if(typeof Infinitas.params.prefix == 'undefined'){
 	Infinitas.params.prefix = 'frontend';
 }
 
-/**
- *
- * @access public
- * @return void
- **/
-function focus(){
-	$(':input:visible:first').focus();
-}
-
 switch(Infinitas.params.prefix) {
 	case 'admin':
 		require([
@@ -50,7 +41,7 @@ switch(Infinitas.params.prefix) {
 		function(require) {
 			$(document).ready(function(){
 				$('.tabs').tabs();
-				focus();
+				$.FormHelper.foucusOnFirst();
 				setupAjaxDropdowns();
 				setupRowSelecting();
 				setupDatePicker();
@@ -89,7 +80,6 @@ switch(Infinitas.params.prefix) {
 		function(require) {
 			$(document).ready(function(){
 				$('.tabs').tabs();
-				focus();
 				$("#side_bar").show().jixedbar();
 				//setupStarRating();
 

diff --git a/extensions/libs/webroot/js/libs/form.js b/extensions/libs/webroot/js/libs/form.js
@@ -1,6 +1,17 @@
 (function($) {
 	var FormHelper = $.FormHelper = {};
 
+	/**
+	 * Focus on the first available text field, used in admin to make the
+	 * overall usability a bit better.
+	 *
+	 * @access public
+	 * @return void
+	 **/
+	FormHelper.foucusOnFirst = function(){
+		$("input:text:visible:first").focus();
+	}
+
 	/**
 	 * generate a form input
 	 */