Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build #3397

Closed
wants to merge 89 commits into from
Closed

Build #3397

wants to merge 89 commits into from

Conversation

michielbdejong
Copy link

This PR fixes bug #.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

New feature description

Checklist

  • All acceptance criteria are met.
  • Relevant documentation, if any, has been written/updated.
  • The changelog has been updated, if applicable.
  • New functions/types have been exported in index.ts, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

This PR bumps the version to .

Release Steps

  1. Look at the CHANGELOG.md to determine whether the release should be a major, minor, or patch release. Coordinate with the team to ensure the next version is agreed upon.
  2. Run npm run lerna-version -- <major|minor|patch> with the decided on version.
  3. Update the CHANGELOG.md to release the latest the version, and set the release date.
  4. Commit the changes on a release/vX.Y.Z branch
  5. Push to GitHub, create a PR, and merge once CI passes.
  6. Create a release on GitHub for the new version, using a combination of the release notes from the CHANGELOG.md and the automatically generated changes.

michielbdejong and others added 22 commits February 16, 2021 10:25
version bump, form-urlencoded bump
Node-fetch is stale, causes problems in downstream libraries, and is now replaceable with  the better native fetch function in node.js.  I wasn't able to build solid-auth-fetcher, but I think you'll find that commenting it out gives you a better fetch.  If you have to import something, try cross-fetch which is at least updated.  BTW I still use solid-auth-fetcher in solid-shell which has at least one user (he copies his timbl.com to his desktop with it).
@michielbdejong michielbdejong requested a review from a team as a code owner March 11, 2024 13:56
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-client-authn-js ❌ Failed (Inspect) Mar 11, 2024 2:15pm

@NSeydoux
Copy link
Contributor

What is this PR about? It is way too massive for a review, so if there are specific changes included in it that you want to suggest for inclusion in the upstream codebase, they will have to be isolated in much smaller units.

@NSeydoux NSeydoux closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants