Adjust heading line-height so descenders correctly show, closes #589

ionic-team · Feb 17, 2014 · 3901b74 · 3901b74
1 parent f736ae5
commit 3901b74
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -34,7 +34,7 @@ $line-height-small:              1.5 !default;
 
 $headings-font-family:           $font-family-base !default;
 $headings-font-weight:           500 !default;
-$headings-line-height:           1.1 !default;
+$headings-line-height:           1.2 !default;
 
 $base-background-color:          #fff;
 $base-color:                     #000;

diff --git a/test/lists.html b/test/lists.html
@@ -474,8 +474,8 @@ <h2>License To Ill</h2>
           <a href="#" class="item item-avatar">
             <div class="item-content">
               <img src="http://ecx.images-amazon.com/images/I/61e6mUocZNL.jpg">
-              <h2>Dookie</h2>
-              <p>Green Day</p>
+              <h2>gjpqy</h2>
+              <p>Test descenders.</p>
             </div>
           </a>
 

diff --git a/test/type.html b/test/type.html
@@ -2,10 +2,13 @@
   <head>
     <meta charset="utf-8">
     <title>Test</title>
-
-    <!-- Sets initial viewport load and disables zooming  -->
     <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no">
     <link href="../dist/css/ionic.css" rel="stylesheet">
+    <style>
+      * {
+        overflow: hidden;
+      }
+    </style>
   </head>
   <body>
 
@@ -14,12 +17,12 @@ <h1 class="title">Type</h1>
     </header>
 
     <main class="content padding has-header">
-      <h1>I'm an H1 Element</h1>
-      <h2>I'm an H2 Element</h2>
-      <h3>I'm an H3 Element</h3>
-      <h4>I'm an H4 Element</h4>
-      <h5>I'm an H5 Element</h5>
-      <h6>I'm an H6 Element</h6>
+      <h1>I'm an H1 Element: gjpqy</h1>
+      <h2>I'm an H2 Element: gjpqy</h2>
+      <h3>I'm an H3 Element: gjpqy</h3>
+      <h4>I'm an H4 Element: gjpqy</h4>
+      <h5>I'm an H5 Element: gjpqy</h5>
+      <h6>I'm an H6 Element: gjpqy</h6>
       <p>I'm a paragraph Element!</p>
       <p>As am I'm a paragraph Element too.</p>
       <hr>