Skip to content

Commit

Permalink
fix(modal): card-style modal now opens at full width on larger devices (
Browse files Browse the repository at this point in the history
#20256)

fixes #20255
  • Loading branch information
liamdebeasi committed Jan 21, 2020
1 parent 32a7401 commit 443cbd9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions core/src/components/modal/modal.ios.scss
Expand Up @@ -21,6 +21,7 @@

:host(.modal-card) {
--backdrop-opacity: 0.15;
--width: 100%;

align-items: flex-end;
}
Expand Down
2 changes: 2 additions & 0 deletions core/src/components/modal/readme.md
Expand Up @@ -157,6 +157,8 @@ export class CalendarComponentModule {}

Modals in iOS mode have the ability to be presented in a card-style and swiped to close. The card-style presentation and swipe to close gesture are not mutually exclusive, meaning you can pick and choose which features you want to use. For example, you can have a card-style modal that cannot be swiped or a full sized modal that can be swiped.

If you are creating an application that uses `ion-tabs`, it is recommended that you get the parent `ion-router-outlet` using `this.routerOutlet.parentOutlet.nativeEl`, otherwise the tabbar will not scale down when the modal opens.

```javascript
import { IonRouterOutlet } from '@ionic/angular';

Expand Down
2 changes: 2 additions & 0 deletions core/src/components/modal/usage/angular.md
Expand Up @@ -135,6 +135,8 @@ export class CalendarComponentModule {}

Modals in iOS mode have the ability to be presented in a card-style and swiped to close. The card-style presentation and swipe to close gesture are not mutually exclusive, meaning you can pick and choose which features you want to use. For example, you can have a card-style modal that cannot be swiped or a full sized modal that can be swiped.

If you are creating an application that uses `ion-tabs`, it is recommended that you get the parent `ion-router-outlet` using `this.routerOutlet.parentOutlet.nativeEl`, otherwise the tabbar will not scale down when the modal opens.

```javascript
import { IonRouterOutlet } from '@ionic/angular';

Expand Down

0 comments on commit 443cbd9

Please sign in to comment.