Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(item-divider): update design to match native iOS (#20854)
- Loading branch information
1 parent
976e68d
commit 8660e61
Showing
9 changed files
with
177 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { newE2EPage } from '@stencil/core/testing'; | ||
|
||
test('item-divider: spec', async () => { | ||
const page = await newE2EPage({ | ||
url: '/src/components/item-divider/test/spec?ionic:_testing=true' | ||
}); | ||
|
||
const compare = await page.compareScreenshot(); | ||
expect(compare).toMatchScreenshot(); | ||
}); | ||
|
||
test('item-divider: spec-rtl', async () => { | ||
const page = await newE2EPage({ | ||
url: '/src/components/item-divider/test/spec?ionic:_testing=true&rtl=true' | ||
}); | ||
|
||
const compare = await page.compareScreenshot(); | ||
expect(compare).toMatchScreenshot(); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
<!DOCTYPE html> | ||
<html dir="ltr"> | ||
|
||
<head> | ||
<meta charset="UTF-8"> | ||
<title>Item Divider - Spec</title> | ||
<meta name="viewport" | ||
content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover"> | ||
<link href="../../../../../css/ionic.bundle.css" rel="stylesheet"> | ||
<link href="../../../../../scripts/testing/styles.css" rel="stylesheet"> | ||
<script src="../../../../../scripts/testing/scripts.js"></script> | ||
<script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
<script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script></head> | ||
|
||
<body> | ||
<ion-app> | ||
|
||
<ion-header> | ||
<ion-toolbar> | ||
<ion-title>Item Divider - Spec</ion-title> | ||
</ion-toolbar> | ||
</ion-header> | ||
|
||
<ion-content> | ||
<ion-list> | ||
<ion-list-header> | ||
<ion-label> | ||
Item Groups | ||
</ion-label> | ||
</ion-list-header> | ||
|
||
<ion-item-group> | ||
<ion-item-divider> | ||
<ion-label>A</ion-label> | ||
</ion-item-divider> | ||
|
||
<ion-item> | ||
<ion-label><b>Abigail</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Jesse <b>Adams</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label><b>Alan</b></ion-label> | ||
</ion-item> | ||
</ion-item-group> | ||
|
||
<ion-item-group> | ||
<ion-item-divider> | ||
<ion-label>B</ion-label> | ||
</ion-item-divider> | ||
|
||
<ion-item> | ||
<ion-label>James <b>Bach</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Flora <b>Ball</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>London <b>Black</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Alisha <b>Brady</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label><b>Brianna</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Monica <b>Brown</b></ion-label> | ||
</ion-item> | ||
</ion-item-group> | ||
|
||
<ion-item-group> | ||
<ion-item-divider> | ||
<ion-label>C</ion-label> | ||
</ion-item-divider> | ||
|
||
<ion-item> | ||
<ion-label><b>Carla</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Brian <b>Clark</b></ion-label> | ||
</ion-item> | ||
|
||
<ion-item> | ||
<ion-label>Robert <b>Cline</b></ion-label> | ||
</ion-item> | ||
</ion-item-group> | ||
</ion-list> | ||
</ion-content> | ||
</ion-app> | ||
</body> | ||
|
||
<style> | ||
.ios ion-item { | ||
--min-height: 44px; | ||
} | ||
|
||
.ios ion-item ion-label { | ||
margin: 0; | ||
} | ||
|
||
.ios ion-item:last-of-type { | ||
--inner-border-width: 0; | ||
} | ||
|
||
.md ion-item:last-of-type { | ||
--inner-border-width: 0; | ||
--border-width: 0 0 1px 0; | ||
} | ||
</style> | ||
|
||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters