Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(picker): pass data and role to the dismiss based on button click or backdrop #19787

Merged
merged 4 commits into from Oct 30, 2019
Merged

fix(picker): pass data and role to the dismiss based on button click or backdrop #19787

merged 4 commits into from Oct 30, 2019

Commits on Oct 29, 2019

  1. fix(picker): pass role to the dismiss on button click and backdrop 

    fixes #18454
    @brandyscarney
    brandyscarney committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    80a383e View commit details
    Browse the repository at this point in the history

  2. fix(picker): return selected if the role is not cancel or backdrop

    @brandyscarney
    brandyscarney committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    aebfdfc View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. fix(picker): call cancel handler on will dismiss

    @brandyscarney
    brandyscarney committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    27e22a0 View commit details
    Browse the repository at this point in the history

  2. fix(picker): reference buttons directly

    @brandyscarney
    brandyscarney committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    17ba690 View commit details
    Browse the repository at this point in the history