Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return refs when creating overlay and controller components #19925

Closed
wants to merge 1 commit into from

Conversation

aub
Copy link
Contributor

@aub aub commented Nov 15, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19924

As described in the issue above, it's currently not possible to pass a ref to any components created with createControllerComponent or createOverlayComponent.

What is the new behavior?

This changes those functions to returns refs, like createComponent does, which should fix the problem, although I'm struggling with how to verify that. Since there's not really a test suite at the moment, how do you verify that changes like this have the desired effect?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@aub aub changed the title reffin Return refs when creating overlay and controller components Nov 16, 2019
@elylucas elylucas added the package: react @ionic/react package label Nov 21, 2019
@liamdebeasi
Copy link
Contributor

Hey there, apologies for the delay. Thank you for the PR! We appreciate the work you put in to create this.

It looks like this got fixed in #20012, so I am going to close this PR. Please update to the latest version of Ionic React to receive this bug fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants