Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(searchbar): set inputmode default to undefined #20080

Merged
merged 7 commits into from Dec 16, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/api.txt
Expand Up @@ -955,7 +955,7 @@ ion-searchbar,prop,clearIcon,string | undefined,undefined,false,false
ion-searchbar,prop,color,string | undefined,undefined,false,false
ion-searchbar,prop,debounce,number,250,false,false
ion-searchbar,prop,disabled,boolean,false,false,false
ion-searchbar,prop,inputmode,"decimal" | "email" | "none" | "numeric" | "search" | "tel" | "text" | "url",'search',false,false
ion-searchbar,prop,inputmode,"decimal" | "email" | "none" | "numeric" | "search" | "tel" | "text" | "url" | undefined,undefined,false,false
ion-searchbar,prop,mode,"ios" | "md",undefined,false,false
ion-searchbar,prop,placeholder,string,'Search',false,false
ion-searchbar,prop,searchIcon,string | undefined,undefined,false,false
Expand Down
2 changes: 1 addition & 1 deletion core/src/components.d.ts
Expand Up @@ -2179,7 +2179,7 @@ export namespace Components {
/**
* A hint to the browser for which keyboard to display. Possible values: `"none"`, `"text"`, `"tel"`, `"url"`, `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
*/
'inputmode': 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';
'inputmode'?: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';
/**
* The mode determines which platform styles to use.
*/
Expand Down
47 changes: 28 additions & 19 deletions core/src/components/searchbar/readme.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/src/components/searchbar/searchbar.tsx
Expand Up @@ -87,7 +87,7 @@ export class Searchbar implements ComponentInterface {
* Possible values: `"none"`, `"text"`, `"tel"`, `"url"`,
* `"email"`, `"numeric"`, `"decimal"`, and `"search"`.
*/
@Prop() inputmode: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search' = 'search';
@Prop() inputmode?: 'none' | 'text' | 'tel' | 'url' | 'email' | 'numeric' | 'decimal' | 'search';

/**
* Set the input's placeholder.
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/searchbar/usage/angular.md
Expand Up @@ -42,4 +42,4 @@
<ion-toolbar>
<ion-searchbar></ion-searchbar>
</ion-toolbar>
```
```
2 changes: 1 addition & 1 deletion core/src/components/searchbar/usage/javascript.md
Expand Up @@ -42,4 +42,4 @@
<ion-toolbar>
<ion-searchbar></ion-searchbar>
</ion-toolbar>
```
```
2 changes: 1 addition & 1 deletion core/src/components/searchbar/usage/react.md
Expand Up @@ -49,4 +49,4 @@ export const SearchbarExample: React.FC = () => (
</IonToolbar>
</IonContent>
);
```
```
2 changes: 1 addition & 1 deletion core/src/components/searchbar/usage/vue.md
Expand Up @@ -44,4 +44,4 @@
<ion-searchbar></ion-searchbar>
</ion-toolbar>
</template>
```
```