Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(header): collapsable header should default to using content background #20736

Merged
merged 4 commits into from Mar 11, 2020
Merged

fix(header): collapsable header should default to using content background #20736

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3941e1c
collapsable toolbar should have same bg as content
liamdebeasi Mar 10, 2020
175202d
rearrange comment
liamdebeasi Mar 10, 2020
0936027
Merge remote-tracking branch 'origin/master' into large-title-toolbar-bg
liamdebeasi Mar 10, 2020
0f5b4d1
Update core/src/components/header/header.ios.scss
liamdebeasi Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/components/header/header.ios.scss
View file
Open in desktop
Expand Up @@ -50,7 +50,13 @@
z-index: 1;
}

/**
* Large title toolbar should just use the content background
* since it needs to blend in with the header above it.
*/
.header-collapse-condense ion-toolbar {
--background: var(--ion-background-color, #fff);
liamdebeasi marked this conversation as resolved.
Show resolved Hide resolved

z-index: 0;
}

Expand Down Expand Up @@ -81,4 +87,4 @@
.header-collapse-condense-inactive.header-collapse-condense ion-toolbar.in-toolbar ion-title,
.header-collapse-condense-inactive.header-collapse-condense ion-toolbar.in-toolbar ion-buttons.buttons-collapse {
visibility: hidden;
}
}