feat(ionicContent): use child scope instead of isolate scope #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new '$ionicBindParent' service, which takes an object containing binding definitions (similar to angular directive isolate scope definition). Allows binding of any parent scope & directive attributes to a child scope, letting us do normal parent -> child scope binding without having to create isolate scopes. Closes #555
|
Realized a flaw in the way I was doing ionicBind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new '$ionicBindParent' service, which takes an object containing
binding definitions (similar to angular directive isolate scope
definition). Allows binding of any scope and attributes from any parent
scope, letting us do normal parent -> child scope binding without having
to create isolate scopes.
Closes #555.
We could refactor many current isolate scope directives to use this, as well, and fix many inheritance / controller problems.