Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Dockerfile order to create VOLUME under user ipfs #1806

Closed
wants to merge 1 commit into from

Conversation

ChristianKniep
Copy link
Contributor

License: MIT
Signed-off-by: Christian Kniep christian@qnib.org

Changed the commit message...

License: MIT
Signed-off-by: Christian Kniep <christian@qnib.org>
@whyrusleeping
Copy link
Member

this seems correct to me, @jbenet @Luzifer ?

@Luzifer
Copy link
Member

Luzifer commented Oct 8, 2015

Hadn't time to test yet but either it makes things better or it doesn't change things. So no negative results expected. LGTM

@jbenet
Copy link
Member

jbenet commented Oct 9, 2015

would be good to have a sharness test that tests the Dockerfile

@whyrusleeping
Copy link
Member

test it by running a docker image with the file?

@jbenet
Copy link
Member

jbenet commented Oct 9, 2015

yep!

On Friday, October 9, 2015, Jeromy Johnson notifications@github.com wrote:

test it by running a docker image with the file?


Reply to this email directly or view it on GitHub
#1806 (comment).

@whyrusleeping
Copy link
Member

are we saying that a test on the dockerfile is a hard requirement for this PR?

@jbenet
Copy link
Member

jbenet commented Oct 11, 2015

Well We should confirm it works, and that it be broken again. If not now, when?

@whyrusleeping
Copy link
Member

just clarifying so we know what tasks need to be done before this PR can merge.

@jbenet
Copy link
Member

jbenet commented Oct 11, 2015

@ChristianKniep are you familiar with our sharness testing and would you have time to do this?

else, is anyone else able to?

@ghost
Copy link

ghost commented Dec 22, 2015

continued in #2064

@ghost ghost closed this Dec 22, 2015
@jbenet jbenet removed the backlog label Dec 22, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants