Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the system use env to find echo #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Krutonium
Copy link

On my (NixOS) system it was showing errors because the echo binary is not where it might normally be. Using /usr/bin/env should be universal and ensure that the echo binary can be found.

@NiKiZe
Copy link
Contributor

NiKiZe commented May 1, 2022

This adds new dependency on /usr/bin/env in Makefile since it is not used anywhere before? How they are used in utils.

One could also argue that NixOS is the odd one here, but unless there is a good reason against this I think it should be valid to be merged. (after confirming to https://ipxe.org/admin, please update commit and PR, force push will be needed)

@stappersg

This comment was marked as abuse.

@Krutonium
Copy link
Author

Krutonium commented May 3, 2022

This adds new dependency on /usr/bin/env in Makefile since it is not used anywhere before? How they are used in utils.

One could also argue that NixOS is the odd one here, but unless there is a good reason against this I think it should be valid to be merged. (after confirming to https://ipxe.org/admin, please update commit and PR, force push will be needed)

I suppose it does, but I have yet to see a system that doesn't have /usr/bin/env, including on systems like mine where echo is located at /run/current-system/sw/bin/echo which is actually a symlink to /nix/store/x5f50z1kgdxmbjw65p84ifqybphc12c3-coreutils-full-9.0/bin/echo

Idea: Install /bin/echo as build dependency.

My websearch on NixOS /bin/echo yielded:

* [known problem](https://github.com/hmemcpy/milewski-ctfp-pdf/issues/208)

* [workaround](https://github.com/hmemcpy/milewski-ctfp-pdf/issues/209)

Perhaps using printf would indeed be cleaner, thoughts in general from others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants