Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nfs] Fix potential buffer overflow condition #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajyoung-oracle
Copy link
Contributor

Fix potential buffer overflow condition in nfs_uri.c.

Signed-off-by: Aaron Young aaron.young@oracle.com

Fix potential buffer overflow condition in nfs_uri.c.

Signed-off-by: Aaron Young <aaron.young@oracle.com>
Copy link
Contributor

@stappersg stappersg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it makes sense to malloc() an extra sizeof(char).

@justinclift
Copy link

@mcb30 This seems like it should be merged?

@mcb30
Copy link
Member

mcb30 commented Apr 2, 2024

@mcb30 This seems like it should be merged?

It's a definite bugfix, but in all honesty the whole NFS and 802.11 code needs replacing because it's full of errors such as these. (This is why those two code areas are not allowed in Secure Boot builds.)

@justinclift
Copy link

No worries. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants