Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Respect value of $(CC) variable #875

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[build] Respect value of $(CC) variable #875

wants to merge 1 commit into from

Conversation

mcb30
Copy link
Member

@mcb30 mcb30 commented Feb 1, 2023

On FreeBSD the gcc package installs a versioned binary such as "gcc12". There is no plain "gcc" binary.

Simplify building on such systems by respecting the $(CC) variable.

Signed-off-by: Michael Brown mcb30@ipxe.org

@mcb30 mcb30 mentioned this pull request Feb 1, 2023
On FreeBSD the gcc package installs a versioned binary such as
"gcc12".  There is no plain "gcc" binary.

Simplify building on such systems by respecting the $(CC) variable.

Modified-by: Michael Brown <mcb30@ipxe.org>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
@stappersg

This comment was marked as abuse.

@mcb30
Copy link
Member Author

mcb30 commented Feb 2, 2023

Will the commit message get a Reported-by dyeske or something simular? (See also #723)

Check the author of the commit.

@stappersg

This comment was marked as abuse.

@dyeske
Copy link

dyeske commented Feb 2, 2023

After the update I have 3 green builds. https://github.com/dyeske/ipxe/actions/runs/4076470975

@dyeske
Copy link

dyeske commented Jun 4, 2023

I think this is fixed in my branch. Please let me know what I need to do. https://github.com/dyeske/ipxe/actions/runs/4076470975

stappersg

This comment was marked as abuse.

@dyeske
Copy link

dyeske commented Aug 10, 2023

Is there anything I need to do for this? I fixed the build.

@stappersg
Copy link
Contributor

How to retrigger the CI tests for this merge request?

And is it something that I can do?

Elaborating those questions:

This merge request was created for researching the effect of #723. It did yield that the ARM32 and ARM64 build environments are not complete as x86. Meanwhile has a year passed and there is "The logs for this run have expired and are no longer available". It makes sense to retrigger the CI. It will at least bring fresh logs, it might even reveal that all architecture now build successful.

Something different:
Currently are here comments marked as abuse. Clicking on show comment shows that the abuse is abuse of power. The "This comment was marked as abuse" is actual

I don't like you, I have the power to silence you, I use that power to do so!

@stappersg
Copy link
Contributor

How to retrigger the CI tests for this merge request?

And is it something that I can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants