Issue 73 #100
Merged
Issue 73 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinKyleJames
force-pushed
the
issue_73
branch
3 times, most recently
from
0348cf6
to
a6480c1
Compare
|
I got help from Globus on how to test this. I added a test case for it. |
JustinKyleJames
force-pushed
the
issue_73
branch
2 times, most recently
from
3d62bd0
to
7086a36
Compare
|
I rebased this on main after issue 65 was merged. |
|
looks good - this passes the tests? are you going to squash to one? or two (code+test)? |
Yes, it passes the tests. I'll squash to one I think. |
|
Seems good. |
|
I squashed with no pound. |
|
yep - i think we're ready for undrafting and some @alanking eyeballs. |
korydraughn
reviewed
May 12, 2024
korydraughn
approved these changes
May 13, 2024
alanking
reviewed
May 13, 2024
|
I updated the commit message to state "preserve file modification time" instead of "preserve replica". I think my brain was on autopilot when I wrote the original message. |
|
If the tests pass, let's squash it. |
done |
Add test for modify time preservation
done |
alanking
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening in draft mode while I figure out how to test this.
Ignore commit for issue 65 as this will be rebased on that once its pull request is finished.