Add Charts support Property #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Jul 10, 2017
| import org.apache.commons.codec.binary.Base64; | ||
|
|
||
|
|
||
| public class Base64Serializer { |
There was a problem hiding this comment.
Is this class really needed ?
Java 8 provides java.util.Base64.
Wicket also provides org.apache.wicket.util.crypt.Base64 (deprecated in Wicket 8.x)
There was a problem hiding this comment.
I see now that it has been extracted from WickedChartSemanticsProvider
| final ObjectAdapter chartAdapter = model.getObject(); | ||
| final Object chartObj = chartAdapter.getObject(); | ||
| PopChart chart = (PopChart) chartObj; | ||
| Options options = chart.getOptions(); |
There was a problem hiding this comment.
Maybe instead of adding more XyzChart classes it would be better to add HichchartsOptionsProvider - a class that provides Options somehow. This way one can create any chart type supported by Highcharts/Wickedcharts.
There was a problem hiding this comment.
I tried at first to modify WickedChart and WickedChartSemanticProvider and not add more XyzChart, but I failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creat PopCharts that can show in HomePage , and show as property as well.