Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

CC @howardjohn @zirain

/test all

Yeah I'm not sure about what to do with the tests. The snippets where we use the MeshConfig to set the percentage sampling or the Telemetry API can be tested but as I said above, it's just starting Istio. Not much we can test regarding the rest.

For the snippet that uses a custom sampler (The only now is the Dynatrace sampler) also can't be really tested as spans are exported to a Dynatrace environment and I doubt we want that in the tests.

So I'm not sure there's much value in it. But if it's required, then I can add some, to at least make sure Istio starts.

@dhawton @linsun I added now tests for configuring percentage sampling via meshConfig and via telemetry API. For the "custom sampler" example, I can't as for that I'd need to deploy a ServiceEntry for the Dynatrace API, and I doubt we want that in a test.

Hi @dhawton @linsun friendly ping on this one.

cc @zirain

Hi all, sorry for the ping, but is there anything else to do here before we merge?

/retest

LGTM.. you can just take care of Daniel's comments, and we are good to go

LGTM.. you can just take care of Daniel's comments, and we are good to go

@kfaseela Done! thank you!

/retest