This repository has been archived by the owner on Aug 15, 2022. It is now read-only.
Nested Boolean Fix and Support to Range with Infinity Value #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated method 'Asari#convert_date_or_time' to check if field belongs to class Time, DateTime, Date or a subclass of any of those three. The solution applied was proposed by @jwarchol in the issue. Implemented tests for the mentioned method. Fixed hardcoded Dates in "documents_spec.rb" that caused a false negative due to Time Zone differences.
Added support to ranges that begins with -Infinite or ends with Infinite according to AWS CloudSearch Documentation.
The url created for a nested boolean search was invalid due to lacking whitespace.
Nested Boolean Search Fix
|
I was just about to fork and add support for Ranges and LatLon. I don't want to duplicate work that has already been done but waiting for merge assistance. Does anyone know if this repo is still being maintained? Our company is currently using CloudSearchable but I've been doing exploratory work on moving us to Asari. The CloudSearchable team has disbanded and no one is contributing. |
Added basic facet support, no sorting or constraints implemented yet. Updated spec syntax to latest valid RSpec syntax.
Increased version number.
Implemented required attributes in the collection object.
Basic Facet Support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to Ranges that contains Infinity, correct translation to CS syntax implemented.
Nested Boolean Search was failing due to invalid URL, missing whitespace before parenthesis was the cause.