Skip to content

Commit

Permalink
Merge pull request #185 from jackalope/jackrabbit-command-nullable
Browse files Browse the repository at this point in the history
make defaults for jackrabbit nullable
  • Loading branch information
dbu committed Feb 19, 2024
2 parents 4a22a0b + 087fe60 commit e42afc4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/Jackalope/Tools/Console/Command/JackrabbitCommand.php
Expand Up @@ -19,17 +19,17 @@ class JackrabbitCommand extends Command
/**
* Path to Jackrabbit jar file.
*/
private string $jackrabbit_jar;
private ?string $jackrabbit_jar = null;

/**
* Path to the Jackrabbit workspace dir.
*/
private string $workspace_dir;
private ?string $workspace_dir = null;

/**
* TCP port of the Jackrabbit HTTP server.
*/
private int $port;
private ?int $port = null;

protected function configure(): void
{
Expand All @@ -50,12 +50,12 @@ protected function configure(): void
);
}

protected function setJackrabbitPath($jackrabbit_jar): void
protected function setJackrabbitPath(?string $jackrabbit_jar): void
{
$this->jackrabbit_jar = $jackrabbit_jar;
}

protected function setWorkspaceDir($workspace_dir): void
protected function setWorkspaceDir(?string $workspace_dir): void
{
$this->workspace_dir = $workspace_dir;
}
Expand Down

0 comments on commit e42afc4

Please sign in to comment.