New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Acl #274
base: 2.x
Are you sure you want to change the base?
Conversation
public function __construct(PrincipalInterface $principal, array $privileges) | ||
{ | ||
$this->principal = $principal; | ||
// TODO: validate privileges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not needed, since the privilege instances will already be "validated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i meant is validate that its actually PrivilegeInterface instances, in case somebody tries to set them with strings or something like that.
case Operation::SET_POLICY: | ||
$this->transport->setPolicy($operations); | ||
break; | ||
//TODO: operation for acl changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik there is no different operation, the acl is always entirely overwritten. right @Alfusainey ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but there is one for REMOVE_POLICY
No description provided.