Fixed positioning of the Box #684
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Top", "Left", "Right", "Bottom" positioning settings were not taken into account as "top" and "left" vars were not used in $box.css() assignment. (Now on line jackmoore#648). On the other hand, scrollTop or scrollLeft isn't needed as fixed / aboslute positioning is set by CSS "position" attribute.
|
Does this affect behavior of ColorBox (e.g. fixes some display problem)? |
Finished last fix.
|
Yes. Without this fix, positioning settings were not taken into account. |
|
I thought ColorBox is always positioned in the center of the screen and if I use mouse wheel to scroll main page then it still stays in the center. |
|
No. You should be able to control position. |
|
It's really strange, that whole repositioning system wasn't working all the time as you say. |
|
It seems it is not one of the most used features... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Top", "Left", "Right", "Bottom" positioning settings were not taken into account as "top" and "left" vars were not used in $box.css() assignment. (Now on line #648).
On the other hand, scrollTop or scrollLeft isn't needed as fixed / aboslute positioning is set by CSS "position" attribute.