Enable to use customized file name #71

nard-tech · 2018-04-28T16:28:54Z

Please check this PR after #72.

After this PR merged we can use customized file names by overriding Seedbank.original_seeds_file

houndci-bot · 2018-04-28T16:29:04Z

lib/tasks/seed.rake

@@ -1,12 +1,16 @@
 # frozen_string_literal: true
+require Rails.root.join('config', 'initializers', 'seedbank.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:04Z

lib/seedbank/runner.rb

@@ -49,6 +49,9 @@ def let!(name, &block)
    def evaluate(seed_task, seed_file)
      @_seed_task = seed_task
      instance_eval(File.read(seed_file), seed_file)
+    rescue Errno::EISDIR => e
+      binding.pry


Lint/Debugger: Remove debugger entry point binding.pry.

houndci-bot · 2018-04-28T16:29:04Z

lib/seedbank/dsl.rb

        task.name
      end

      def original_seeds_file
-        @_seedbank_original ||= existent(Pathname.new('../seeds.rb').expand_path(seeds_root))
+        @_seedbank_original ||= existent(Pathname.new(Seedbank.original_seeds_file).expand_path(seeds_root))


Naming/MemoizedInstanceVariableName: Memoized variable @_seedbank_original does not match method name original_seeds_file. Use @original_seeds_file instead.

houndci-bot · 2018-04-28T16:29:04Z

lib/seedbank/dsl.rb

-        fq_name = scopes.push(File.basename(seed_file, '.seeds.rb')).join(':')
+        scopes = scope_from_seed_file(seed_file)
+        suffix = Seedbank.matcher.gsub(/\A\*/, '')
+        fq_name = scopes.push(File.basename(seed_file, suffix)).join(':')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:04Z

lib/seedbank/dsl.rb

-        scopes  = scope_from_seed_file(seed_file)
-        fq_name = scopes.push(File.basename(seed_file, '.seeds.rb')).join(':')
+        scopes = scope_from_seed_file(seed_file)
+        suffix = Seedbank.matcher.gsub(/\A\*/, '')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:04Z

lib/seedbank.rb

@@ -21,6 +21,10 @@ def nesting
    def matcher
      @matcher ||= '*.seeds.rb'
    end
+
+    def original_seeds_file
+      @original_seeds_file ||= File.join(application_root, 'db', 'seeds.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:05Z

lib/tasks/seed.rake

@@ -1,12 +1,16 @@
 # frozen_string_literal: true
+require Rails.root.join('config', 'initializers', 'seedbank.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:05Z

lib/seedbank/runner.rb

@@ -49,6 +49,9 @@ def let!(name, &block)
    def evaluate(seed_task, seed_file)
      @_seed_task = seed_task
      instance_eval(File.read(seed_file), seed_file)
+    rescue Errno::EISDIR => e
+      binding.pry


Lint/Debugger: Remove debugger entry point binding.pry.

houndci-bot · 2018-04-28T16:29:05Z

lib/seedbank/dsl.rb

        task.name
      end

      def original_seeds_file
-        @_seedbank_original ||= existent(Pathname.new('../seeds.rb').expand_path(seeds_root))
+        @_seedbank_original ||= existent(Pathname.new(Seedbank.original_seeds_file).expand_path(seeds_root))


Naming/MemoizedInstanceVariableName: Memoized variable @_seedbank_original does not match method name original_seeds_file. Use @original_seeds_file instead.

houndci-bot · 2018-04-28T16:29:05Z

lib/seedbank/dsl.rb

-        fq_name = scopes.push(File.basename(seed_file, '.seeds.rb')).join(':')
+        scopes = scope_from_seed_file(seed_file)
+        suffix = Seedbank.matcher.gsub(/\A\*/, '')
+        fq_name = scopes.push(File.basename(seed_file, suffix)).join(':')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:05Z

lib/seedbank/dsl.rb

-        scopes  = scope_from_seed_file(seed_file)
-        fq_name = scopes.push(File.basename(seed_file, '.seeds.rb')).join(':')
+        scopes = scope_from_seed_file(seed_file)
+        suffix = Seedbank.matcher.gsub(/\A\*/, '')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:29:05Z

lib/seedbank.rb

@@ -21,6 +21,10 @@ def nesting
    def matcher
      @matcher ||= '*.seeds.rb'
    end
+
+    def original_seeds_file
+      @original_seeds_file ||= File.join(application_root, 'db', 'seeds.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:38:26Z

lib/seedbank/dsl.rb

        task.name
      end

      def original_seeds_file
-        @_seedbank_original ||= existent(Pathname.new('../seeds.rb').expand_path(seeds_root))
+        @_original_seeds_file ||= existent(Pathname.new(Seedbank.original_seeds_file).expand_path(seeds_root))


Naming/MemoizedInstanceVariableName: Memoized variable @_original_seeds_file does not match method name original_seeds_file. Use @original_seeds_file instead.

houndci-bot · 2018-04-28T16:53:23Z

test/lib/seedbank/dsl_test.rb

+
+    describe 'in an environment directory' do
+      let(:seeds_root) { '/my/seeds/directory' }
+      let(:original_seeds_file) { '/my/original/seed_file.rb' }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:53:23Z

test/lib/seedbank/dsl_test.rb

+    subject { Seedbank::DSL.original_seeds_file }
+
+    describe 'in an environment directory' do
+      let(:seeds_root) { '/my/seeds/directory' }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:53:23Z

test/lib/seedbank/dsl_test.rb

+  describe 'original_seeds_file' do
+    subject { Seedbank::DSL.original_seeds_file }
+
+    describe 'in an environment directory' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T16:53:23Z

test/lib/seedbank/dsl_test.rb

@@ -4,6 +4,19 @@
 using Seedbank::DSL

 describe Seedbank::DSL do
+  describe 'original_seeds_file' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T17:52:11Z

test/lib/seedbank/dsl_test.rb

+    let(:root) { '/my/seeds/directory' }
+
+    it 'returns an expanded path name' do
+      subject.must_equal Pathname.new('/my/seeds/seeds_original.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T17:52:11Z

test/lib/seedbank/dsl_test.rb

+    let(:filename) { '../seeds_original.rb' }
+    let(:root) { '/my/seeds/directory' }
+
+    it 'returns an expanded path name' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T17:52:11Z

test/lib/seedbank/dsl_test.rb

@@ -163,4 +163,15 @@ def define_prerequisite_task
      end
    end
  end
+
+  describe 'original_seeds_file_expanded' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T18:15:09Z

lib/tasks/seed.rake

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
+if defined?(Rails)
+  initializer = Rails.root.join('config', 'initializers', 'seedbank.rb')


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-04-28T18:15:09Z

lib/seedbank/dsl.rb

@@ -40,7 +41,7 @@ def define_seed_task(seed_file, *args)
      end

      def original_seeds_file
-        @_seedbank_original ||= existent(Pathname.new('../seeds.rb').expand_path(seeds_root))
+        @_original_seeds_file ||= existent(original_seeds_file_expanded(Seedbank.original_seeds_file, seeds_root))


Naming/MemoizedInstanceVariableName: Memoized variable @_original_seeds_file does not match method name original_seeds_file. Use @original_seeds_file instead.

houndci-bot · 2018-04-28T18:22:32Z

test/test_helper.rb

@@ -18,7 +18,7 @@ def setup
      Rake.application = Rake::Application.new
      Dummy::Application.load_tasks
      Object.const_set :FakeModel, MiniTest::Mock.new
-      TOPLEVEL_BINDING.eval('self').send(:instance_variable_set, :@_seedbank_runner, Seedbank::Runner.new)
+      TOPLEVEL_BINDING.eval('self').send(:instance_variable_set, :@runner, Seedbank::Runner.new)


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:44Z

test/test_helper.rb

@@ -10,15 +10,15 @@

 Rails.backtrace_cleaner.remove_silencers!

-Seedbank.application_root = Pathname.new(File.expand_path('../dummy', __FILE__))
+Seedbank.application_root = Pathname.new(File.expand_path('dummy', __dir__))


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:45Z

test/lib/seedbank/dsl_test.rb

+    subject { original_seeds_file_expanded(filename, root) }
+
+    let(:filename) { '../seeds_original.rb' }
+    let(:root) { '/my/seeds/directory' }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:45Z

test/lib/seedbank/dsl_test.rb

+  describe 'original_seeds_file_expanded' do
+    subject { original_seeds_file_expanded(filename, root) }
+
+    let(:filename) { '../seeds_original.rb' }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:45Z

test/lib/seedbank/dsl_test.rb


-        Rake::Task[task_name].full_comment.must_equal description
+      it 'must be empty' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:45Z

test/lib/seedbank/dsl_test.rb


-        Seedbank::DSL.override_seed_task(task_name => dependencies)
+      it 'returns an array' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:45Z

test/lib/seedbank/dsl_test.rb

+      let(:seed_file) { File.expand_path('development/shared/accounts.seeds.rb', Seedbank.seeds_root) }
+      let(:seed_namespace) { %w[development shared] }
+
+      it 'returns the nested scope' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:46Z

test/lib/seedbank/dsl_test.rb

+    end
+
+    describe 'in a nested directory' do
+      let(:seed_file) { File.expand_path('development/shared/accounts.seeds.rb', Seedbank.seeds_root) }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:46Z

test/lib/seedbank/dsl_test.rb

+      end
+    end
+
+    describe 'in a nested directory' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:46Z

test/lib/seedbank/dsl_test.rb

+      let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }
+      let(:seed_namespace) { %w[development] }
+
+      it 'returns the enviroment scope' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-05-06T06:33:46Z

test/lib/seedbank/dsl_test.rb


-        Rake::Task[task_name].prerequisite_tasks.must_equal expected_dependencies
+    describe 'in an environment directory' do
+      let(:seed_file) { File.expand_path('development/users.seeds.rb', Seedbank.seeds_root) }


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

james2m · 2018-06-27T08:03:41Z

@nard-tech Sorry for the slow response, I've not had much time recently. This looks good, I'll have a more thorough look at start to build a new release shortly.

nard-tech · 2019-02-02T08:13:13Z

@james2m Sorry for the slow response, too.
Thanks you for merging my PR. I am expecting the release of v1.0.0. Thank you.

houndci-bot reviewed Apr 28, 2018

View reviewed changes

nard-tech force-pushed the feature/enable-to-customize-filename branch from fec03ce to ee8ac53 Compare April 28, 2018 16:38

houndci-bot reviewed Apr 28, 2018

View reviewed changes

nard-tech force-pushed the feature/enable-to-customize-filename branch from 569df14 to 7b274ce Compare April 28, 2018 17:52

houndci-bot reviewed Apr 28, 2018

View reviewed changes

nard-tech force-pushed the feature/enable-to-customize-filename branch 2 times, most recently from 36f941b to 689367d Compare April 28, 2018 18:15

houndci-bot reviewed Apr 28, 2018

View reviewed changes

nard-tech force-pushed the feature/enable-to-customize-filename branch 3 times, most recently from c4d966d to c0900aa Compare April 28, 2018 18:22

houndci-bot reviewed Apr 28, 2018

View reviewed changes

nard-tech force-pushed the feature/enable-to-customize-filename branch from c0900aa to 1b021df Compare April 28, 2018 18:23

nard-tech added 8 commits May 4, 2018 11:50

Sort test cases in order of appearance

088d9a9

Clean styles

bd545e5

Add Seedbank::DSL#original_seeds_file_expanded

e6ef199

Refactor Seedbank::DSL#seed_task_from_file

b7d569f

Add attribute 'original_seeds_file'

a78bbf7

Fix Seedbank::DSL#original_seeds_file

5be4b43

Fix Seedbank::DSL#seed_task_from_file

04ed030

Add require settings

1dc052b

nard-tech force-pushed the feature/enable-to-customize-filename branch from 1b021df to 1dc052b Compare May 6, 2018 06:33

houndci-bot reviewed May 6, 2018

View reviewed changes

nard-tech changed the title ~~[WIP] Enable to use customized file name~~ Enable to use customized file name May 6, 2018

nard-tech mentioned this pull request May 6, 2018

Refactor DSL #72

Merged

james2m added this to the 1.0 milestone Jun 27, 2018

		@@ -1,12 +1,16 @@
		# frozen_string_literal: true
		require Rails.root.join('config', 'initializers', 'seedbank.rb')


		Rake::Task[task_name].full_comment.must_equal description
		it 'must be empty' do


		Seedbank::DSL.override_seed_task(task_name => dependencies)
		it 'returns an array' do

Enable to use customized file name #71

Are you sure you want to change the base?

Enable to use customized file name #71

Conversation

nard-tech commented Apr 28, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

james2m commented Jun 27, 2018

nard-tech commented Feb 2, 2019

nard-tech commented Apr 28, 2018 •

edited