Allow multi-level directories #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 27, 2020
| glob_seed_files_matching('/*/').each do |directory| | ||
| environment = File.basename(directory) | ||
| glob_seed_files_matching('**/*/').each do |directory| | ||
| regex = Regexp.new('(?<=' + Seedbank.seeds_root + ')(.*)') |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -19,8 +19,10 @@ namespace :db do | |||
|
|
|||
| # Glob through the directories under seeds_path and create a task for each adding it to the dependency list. | |||
| # Then create a task for the environment | |||
| glob_seed_files_matching('/*/').each do |directory| | |||
| environment = File.basename(directory) | |||
| glob_seed_files_matching('**/*/').each do |directory| | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
houndci-bot
reviewed
Aug 29, 2020
|
|
||
| name = environment.split("/").select(&:present?).join(":") | ||
| desc "Load the seed data from db/seeds.rb, db/seeds/#{Seedbank.matcher} and db/seeds#{environment}#{Seedbank.matcher}." | ||
| task name => ['db:seed:common'] + environment_dependencies |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| desc "Load the seed data from db/seeds.rb, db/seeds/#{Seedbank.matcher} and db/seeds/#{environment}/#{Seedbank.matcher}." | ||
| task environment => ['db:seed:common'] + environment_dependencies | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
houndci-bot
reviewed
Aug 29, 2020
| @@ -1,4 +1,4 @@ | |||
| # frozen_string_literal: true | |||
| module Seedbank | |||
| VERSION = '0.5.0' | |||
| VERSION = '0.6.0' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to not restrict directory levels to one level only.
rails db:seed:development:default:cars # Load the seed data from db/seeds/development/default/cars.seeds.rbPossible usecase: create tenant-specific rake tasks for multi-tenancy apps