Bring Lua to 5.4.4. #873
Open
Bring Lua to 5.4.4. #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares the ground for bringing Lua up to 5.4.6. It adds some missing copyrights, removes some overlooked copyrights, makes vertical whitespace consistent across files and adds `[jart]` comments in various places to make subsequent Lua comparisons easier. Well. Hopefully. In theory, nothing here is controversial. If we merge this, the 5.4.4 update will be “all signal, no noise.” But the noise level isn’t all that high, so it probably doesn’t matter all that much.
I discovered that five test files were encoded with ISO-8859-1 rather than UTF-8: ``` $ iconv -f UTF-8 third_party/lua/test/*.lua >/dev/null iconv: third_party/lua/test/db.lua:299:33: cannot convert iconv: third_party/lua/test/files.lua:95:18: cannot convert iconv: third_party/lua/test/pm.lua:76:19: cannot convert iconv: third_party/lua/test/sort.lua:292:6: cannot convert iconv: third_party/lua/test/strings.lua:94:39: cannot convert $ file third_party/lua/test/db.lua third_party/lua/test/db.lua: ISO-8859 text $ file third_party/lua/test/files.lua third_party/lua/test/files.lua: ISO-8859 text $ file third_party/lua/test/pm.lua third_party/lua/test/pm.lua: ISO-8859 text $ file third_party/lua/test/sort.lua third_party/lua/test/sort.lua: ISO-8859 text $ file third_party/lua/test/strings.lua third_party/lua/test/strings.lua: ISO-8859 text ```
Some tests — in `files.lua` and `pm.lua` — count bytes. Since the byte count of encoded characters changes from ISO-8859-1 to UTF-8, the tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream Lua 5.4.3 to 5.4.4 diff is here.
The Cosmo Lua 5.4.3 to 5.4.4 diff is here.